The following document contains the results of FindBugs Report
FindBugs Version is 1.2.1
Threshold is Low
Effort is Default
| Classes | Bugs | Errors | Missing Classes |
|---|---|---|---|
| 90 | 23 | 0 | 0 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Redundant nullcheck of attr, which is known to be non-null in org.sonatype.plexus.components.sec.dispatcher.DefaultSecDispatcher.decrypt(String) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 112 |
| Bug | Category | Details | Line |
|---|---|---|---|
| org.sonatype.plexus.components.sec.dispatcher.SecDispatcher.SYSTEM_PROPERTY_MASTER_PASSWORD should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 26 |
| org.sonatype.plexus.components.sec.dispatcher.SecDispatcher.SYSTEM_PROPERTY_SERVER_PASSWORD should be moved out of an interface and made package protected | MALICIOUS_CODE | MS_OOI_PKGPROTECT | 28 |
| Bug | Category | Details | Line |
|---|---|---|---|
| org.sonatype.plexus.components.sec.dispatcher.SecUtil.URL_PROTOCOLS should be package protected | MALICIOUS_CODE | MS_PKGPROTECT | 44 |
| Redundant nullcheck of cl, which is known to be non-null in org.sonatype.plexus.components.sec.dispatcher.SecUtil.getConfig(SettingsSecurity, String) | STYLE | RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE | 110 |
| Exception is caught when Exception is not thrown in org.sonatype.plexus.components.sec.dispatcher.SecUtil.read(String, boolean) | STYLE | REC_CATCH_EXCEPTION | 67 |
| Bug | Category | Details | Line |
|---|---|---|---|
| org.sonatype.plexus.components.sec.dispatcher.model.Config is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 15-109 |
| Method org.sonatype.plexus.components.sec.dispatcher.model.Config.addProperty(ConfigProperty) does an unnecessary type check using instanceof operator when it can be determined statically | CORRECTNESS | SIO_SUPERFLUOUS_INSTANCEOF | 45 |
| Method org.sonatype.plexus.components.sec.dispatcher.model.Config.removeProperty(ConfigProperty) does an unnecessary type check using instanceof operator when it can be determined statically | CORRECTNESS | SIO_SUPERFLUOUS_INSTANCEOF | 84 |
| Bug | Category | Details | Line |
|---|---|---|---|
| org.sonatype.plexus.components.sec.dispatcher.model.ConfigProperty is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 15-76 |
| Bug | Category | Details | Line |
|---|---|---|---|
| org.sonatype.plexus.components.sec.dispatcher.model.SettingsSecurity is Serializable; consider declaring a serialVersionUID | BAD_PRACTICE | SE_NO_SERIALVERSIONID | 15-160 |
| Method org.sonatype.plexus.components.sec.dispatcher.model.SettingsSecurity.addConfiguration(Config) does an unnecessary type check using instanceof operator when it can be determined statically | CORRECTNESS | SIO_SUPERFLUOUS_INSTANCEOF | 55 |
| Method org.sonatype.plexus.components.sec.dispatcher.model.SettingsSecurity.removeConfiguration(Config) does an unnecessary type check using instanceof operator when it can be determined statically | CORRECTNESS | SIO_SUPERFLUOUS_INSTANCEOF | 115 |
| Bug | Category | Details | Line |
|---|---|---|---|
| Private method org.sonatype.plexus.components.sec.dispatcher.model.io.xpp3.SecurityConfigurationXpp3Reader.getBooleanValue(String, String, XmlPullParser) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 103 |
| Private method org.sonatype.plexus.components.sec.dispatcher.model.io.xpp3.SecurityConfigurationXpp3Reader.getDateValue(String, String, XmlPullParser) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 191 |
| Private method org.sonatype.plexus.components.sec.dispatcher.model.io.xpp3.SecurityConfigurationXpp3Reader.getByteValue(String, String, XmlPullParser, boolean) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 143-157 |
| Private method org.sonatype.plexus.components.sec.dispatcher.model.io.xpp3.SecurityConfigurationXpp3Reader.getCharacterValue(String, String, XmlPullParser) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 172-176 |
| Private method org.sonatype.plexus.components.sec.dispatcher.model.io.xpp3.SecurityConfigurationXpp3Reader.getDoubleValue(String, String, XmlPullParser, boolean) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 254-268 |
| Private method org.sonatype.plexus.components.sec.dispatcher.model.io.xpp3.SecurityConfigurationXpp3Reader.getFloatValue(String, String, XmlPullParser, boolean) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 284-298 |
| Private method org.sonatype.plexus.components.sec.dispatcher.model.io.xpp3.SecurityConfigurationXpp3Reader.getIntegerValue(String, String, XmlPullParser, boolean) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 314-328 |
| Private method org.sonatype.plexus.components.sec.dispatcher.model.io.xpp3.SecurityConfigurationXpp3Reader.getLongValue(String, String, XmlPullParser, boolean) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 344-358 |
| Private method org.sonatype.plexus.components.sec.dispatcher.model.io.xpp3.SecurityConfigurationXpp3Reader.getRequiredAttributeValue(String, String, XmlPullParser, boolean) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 374-381 |
| Private method org.sonatype.plexus.components.sec.dispatcher.model.io.xpp3.SecurityConfigurationXpp3Reader.getShortValue(String, String, XmlPullParser, boolean) is never called | PERFORMANCE | UPM_UNCALLED_PRIVATE_METHOD | 397-411 |